Re: [PATCH 2/2] cgroup, docs: Document interaction of RT processes with cpu controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 06, 2025 at 11:02:22AM +0000, "Shashank.Mahadasyam@xxxxxxxx" <Shashank.Mahadasyam@xxxxxxxx> wrote:
> Do you think it should be rephrased to make it clearer?

Aha, I understand now why it confused you (with the paragraph about
realtime tasks right above interface files).

I'd consider such a minimal correction:

--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1076,7 +1076,7 @@ cpufreq governor about the minimum desired frequency which should always be
 provided by a CPU, as well as the maximum desired frequency, which should not
 be exceeded by a CPU.

-WARNING: cgroup2 doesn't yet support control of realtime processes. For
+WARNING: cgroup2 doesn't yet support (bandwidth) control of realtime processes. For
 a kernel built with the CONFIG_RT_GROUP_SCHED option enabled for group
 scheduling of realtime processes, the cpu controller can only be enabled
 when all RT processes are in the root cgroup.  This limitation does


Of course wordier rewrite is possible but I find the text as you
originally proposed unclear due to several uses of "only" that imply
restrictions that aren't in place in reality.

Thanks,
Michal

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux