Hi inwardvessel, kernel test robot noticed the following build errors: [auto build test ERROR on bpf-next/net] [also build test ERROR on bpf-next/master bpf/master linus/master v6.14-rc5] [cannot apply to tj-cgroup/for-next next-20250303] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/inwardvessel/cgroup-move-cgroup_rstat-from-cgroup-to-cgroup_subsys_state/20250228-055819 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git net patch link: https://lore.kernel.org/r/20250227215543.49928-4-inwardvessel%40gmail.com patch subject: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250304/202503040736.kEeH1wt6-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503040736.kEeH1wt6-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202503040736.kEeH1wt6-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from arch/loongarch/include/asm/bug.h:61, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from include/asm-generic/current.h:6, from ./arch/loongarch/include/generated/asm/current.h:1, from include/linux/sched.h:12, from include/linux/cgroup.h:12, from kernel/cgroup/cgroup-internal.h:5, from kernel/cgroup/rstat.c:2: kernel/cgroup/rstat.c: In function 'cgroup_rstat_flush_locked': >> include/linux/lockdep.h:252:61: error: 'lock' is a pointer; did you mean to use '->'? 252 | #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) | ^~ include/asm-generic/bug.h:123:32: note: in definition of macro 'WARN_ON' 123 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ include/linux/lockdep.h:285:9: note: in expansion of macro 'lockdep_assert' 285 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~ include/linux/lockdep.h:285:24: note: in expansion of macro 'lockdep_is_held' 285 | lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD) | ^~~~~~~~~~~~~~~ kernel/cgroup/rstat.c:339:9: note: in expansion of macro 'lockdep_assert_held' 339 | lockdep_assert_held(&lock); | ^~~~~~~~~~~~~~~~~~~ vim +252 include/linux/lockdep.h f607c668577481 Peter Zijlstra 2009-07-20 251 f8319483f57f1c Peter Zijlstra 2016-11-30 @252 #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map) f8319483f57f1c Peter Zijlstra 2016-11-30 253 #define lockdep_is_held_type(lock, r) lock_is_held_type(&(lock)->dep_map, (r)) f607c668577481 Peter Zijlstra 2009-07-20 254 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki