On Mon, Feb 17, 2025 at 07:14:39PM -0800, JP Kobryn wrote: > Change the type of rstat node from cgroup to the new cgroup_rstat > struct. Then for the rstat updated/flush api calls, add double under > versions that accept references to the cgroup_rstat struct. This new > level of indirection will allow for extending the public api further. > i.e. the cgroup_rstat struct can be embedded in a new type of object and > a public api can be added for that new type. > > Signed-off-by: JP Kobryn <inwardvessel@xxxxxxxxx> I think the code looks good here but the commit message needs some massaging. From what I understand, you are trying to decouple struct cgroup_rstat from struct cgroup, so later you can move struct cgroup_rstat in different structure (and maybe later some new structure can all include cgroup_rstat to take advantage of rstat infra). I am not sure I would call this "add level of indirection".