On 2/16/25 7:02 AM, Aditya Dutt wrote:
Changes include:
- Replaced [[ ... ]] with [ ... ]
- Replaced == with =
- Replaced printf -v with cur=$(printf ...).
- Replaced echo -e with printf "%b\n" ...
The above mentioned are Bash/GNU extensions and are not part of POSIX.
Using shells like dash or non-GNU coreutils may produce errors.
They have been replaced with POSIX-compatible alternatives.
Signed-off-by: Aditya Dutt <duttaditya18@xxxxxxxxx>
---
I have made sure to only change the files that specifically have the
/bin/sh shebang.
I have referred to https://mywiki.wooledge.org/Bashism for information
on what is and what isn't POSIX-compliant.
tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh | 10 +++++-----
tools/testing/selftests/kexec/kexec_common_lib.sh | 2 +-
tools/testing/selftests/kexec/test_kexec_file_load.sh | 2 +-
tools/testing/selftests/net/veth.sh | 10 +++++-----
tools/testing/selftests/powerpc/eeh/eeh-vf-aware.sh | 2 +-
tools/testing/selftests/zram/zram_lib.sh | 2 +-
6 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh b/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
index 3f45512fb512..00416248670f 100755
--- a/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
+++ b/tools/testing/selftests/cgroup/test_cpuset_v1_hp.sh
@@ -11,24 +11,24 @@ skip_test() {
exit 4 # ksft_skip
}
-[[ $(id -u) -eq 0 ]] || skip_test "Test must be run as root!"
+[ $(id -u) -eq 0 ] || skip_test "Test must be run as root!"
# Find cpuset v1 mount point
CPUSET=$(mount -t cgroup | grep cpuset | head -1 | awk -e '{print $3}')
-[[ -n "$CPUSET" ]] || skip_test "cpuset v1 mount point not found!"
+[ -n "$CPUSET" ] || skip_test "cpuset v1 mount point not found!"
#
# Create a test cpuset, put a CPU and a task there and offline that CPU
#
TDIR=test$$
-[[ -d $CPUSET/$TDIR ]] || mkdir $CPUSET/$TDIR
+[ -d $CPUSET/$TDIR ] || mkdir $CPUSET/$TDIR
echo 1 > $CPUSET/$TDIR/cpuset.cpus
echo 0 > $CPUSET/$TDIR/cpuset.mems
sleep 10&
TASK=$!
echo $TASK > $CPUSET/$TDIR/tasks
NEWCS=$(cat /proc/$TASK/cpuset)
-[[ $NEWCS != "/$TDIR" ]] && {
+[ $NEWCS != "/$TDIR" ] && {
echo "Unexpected cpuset $NEWCS, test FAILED!"
exit 1
}
@@ -38,7 +38,7 @@ sleep 0.5
echo 1 > /sys/devices/system/cpu/cpu1/online
NEWCS=$(cat /proc/$TASK/cpuset)
rmdir $CPUSET/$TDIR
-[[ $NEWCS != "/" ]] && {
+[ $NEWCS != "/" ] && {
echo "cpuset $NEWCS, test FAILED!"
exit 1
}
test_cpuset_v1_hp.sh had been changed to use /bin/bash in v6.14 by
commit fd079124112c ("selftests/cgroup: use bash in test_cpuset_v1_hp.sh").
Cheers,
Longman
