Hi Michal,
Thanks. Please find below the revised version of the patch. If there are still problems with formatting, please let me know.
The CPU usage time is the time when user, system or both are using the CPU.
Steal time is the time when CPU is waiting to be run by the Hypervisor. It should not be
added to the CPU usage time, hence removing it from the usage_usec entry.
Fixes: 936f2a70f2077 ("cgroup: add cpu.stat file to root cgroup")
Acked-by: Axel Busch <axel.busch@xxxxxxx>
Signed-off-by: Muhammad Adeel <muhammad.adeel@xxxxxxx>
---
kernel/cgroup/rstat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c
index 5877974ece92..aac91466279f 100644
--- a/kernel/cgroup/rstat.c
+++ b/kernel/cgroup/rstat.c
@@ -590,7 +590,6 @@ static void root_cgroup_cputime(struct cgroup_base_stat *bstat)
cputime->sum_exec_runtime += user;
cputime->sum_exec_runtime += sys;
- cputime->sum_exec_runtime += cpustat[CPUTIME_STEAL];
#ifdef CONFIG_SCHED_CORE
bstat->forceidle_sum += cpustat[CPUTIME_FORCEIDLE];
--
Regards,
Muhammad
> -----Original Message-----
> From: Michal Koutný <mkoutny@xxxxxxxx>
> Sent: Friday, 7 February 2025 13:09
> To: Muhammad Adeel <Muhammad.Adeel@xxxxxxx>
> Cc: cgroups@xxxxxxxxxxxxxxx; tj@xxxxxxxxxx; hannes@xxxxxxxxxxx; Axel Busch
> <Axel.Busch@xxxxxxx>; Boris Burkov <boris@xxxxxx>
> Subject: [EXTERNAL] Re: Remove steal time from usage_usec
>
> Hi Muhammad.
>
> On Fri, Feb 07, 2025 at 10:23:41AM +0000, Muhammad Adeel
> <Muhammad.Adeel@xxxxxxx> wrote:
> > The CPU usage time is the time when user, system or both are using the CPU.
> > Steal time is the time when CPU is waiting to be run by the
> > Hypervisor. It should not be added to the CPU usage time, hence removing it
> from the usage_usec entry.
>
> It sounds like inclusion of the steal time in the original commit was rather
> accidental (+Cc: Boris), so this sounds a reasonable change.
> Could you also please add
> Fixes: 936f2a70f2077 ("cgroup: add cpu.stat file to root cgroup")
>
>
> > Acked-by: Axel Busch <axel.busch@xxxxxxxx>
> (this doesn't look valid domain)
>
> The mail doesn't have proper patch subject line, I'd suggest the tips from
> Documentation/process/submitting-patches.rst about patch formatting.
>
> Thanks,
> Michal
