On Sat, Jan 25, 2025 at 01:25:11PM +0800, Abel Wu wrote: > There were efforts like b824766504e4 ("cgroup/rstat: add force idle show helper") > to escape from #ifdef hells, and there could be new stats coming out in > the future, let's clean it up once for all. > > Signed-off-by: Abel Wu <wuyun.abel@xxxxxxxxxxxxx> > --- > kernel/cgroup/rstat.c | 47 ++++++++++++++++++++++++------------------- > 1 file changed, 26 insertions(+), 21 deletions(-) Is this materially better? The existing code has ifdef in one place which the new code can't avoid. The new code is more complex and has more lines. Does the balance get better with additions of new entries? Thanks. -- tejun