On Tue, Jan 14, 2025 at 06:56:38PM +0100, Maxime Ripard wrote: > On Tue, Jan 14, 2025 at 10:41:28AM -0500, Waiman Long wrote: > > On 1/14/25 1:28 AM, Jiapeng Chong wrote: > > > Variable climit is not effectively used, so delete it. > > > > > > kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used. > > > > > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13512 > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > > --- > > > kernel/cgroup/dmem.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c > > > index 52736ef0ccf2..78d9361ed521 100644 > > > --- a/kernel/cgroup/dmem.c > > > +++ b/kernel/cgroup/dmem.c > > > @@ -299,7 +299,7 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool, > > > bool ignore_low, bool *ret_hit_low) > > > { > > > struct dmem_cgroup_pool_state *pool = test_pool; > > > - struct page_counter *climit, *ctest; > > > + struct page_counter *ctest; > > > u64 used, min, low; > > > /* Can always evict from current pool, despite limits */ > > > @@ -324,7 +324,6 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool, > > > {} > > > } > > > - climit = &limit_pool->cnt; > > > ctest = &test_pool->cnt; > > > dmem_cgroup_calculate_protection(limit_pool, test_pool); > > > > The dmem controller is actually pulled into the drm tree at the moment. > > > > cc relevant parties on how to handle this fix commit. > > We can either take it through drm with one of the cgroup maintainers > ack, or they can merge the PR in their tree and merge the fixes as they > wish through their tree. Acked-by: Tejun Heo <tj@xxxxxxxxxx> Please route with the rest of dmem changes. Thanks. -- tejun
