On Tue, 24 Dec 2024 20:33:44 +0800 Zijun Hu <zijun_hu@xxxxxxxxxx> wrote: > On 2024/12/24 04:11, Jonathan Cameron wrote: > >> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> > >> > >> The following device finding APIs only have one line code in function body > >> device_find_child_by_name() > >> device_find_any_child() > >> > >> Move them to header as static inline function. > > Why drop the docs? > > > thank you Jonathan for code review. > > will add these comments back in next revision. > > i do not notice the comments include important info, and think the API > name prompts what the API does, so remove the comments. my mistake. I don't mind that much, just that you should state your reasoning in the patch description. Jonathan > > >> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> > >
