On Wed, 30 Oct 2024 16:43:42 -0400 Joshua Hahn <joshua.hahnjy@xxxxxxxxx> wrote: > I saw that it was merged into mm-unstable earlier yesterday. Would it > be possible > to add this block of text to the patch description right before the footnotes? > > 3. Implementation Details: > In the alloc / free hugetlb functions, we call lruvec_stat_mod_folio > regardless of whether memcg accounts hugetlb. lruvec_stat_mod_folio > keys off of folio->memcg which is only set up if the > CGRP_ROOT_MEMORY_HUGETLB_ACCOUTING cgroup mount option is used, so > it will not try to accumulate hugetlb unless the flag is set. > This also ensures that memory.stat::hugetlb is the same as > the share of memory.current that is used by hugetlb pages. Thanks, done. > And could you also update the list of signatures to reflect the > responses on this version? > Suggested-by: Nhat Pham <nphamcs@xxxxxxxxx> > Suggested-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > Suggested-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Acked-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Acked-by: Chris Down <chris@xxxxxxxxxxxxxx> > Reviewed-by: Roman Gushchin <roman.gushchin@xxxxxxxxx> > Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx> > Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx> Done2. I already had all that, plus an ack from Chris Down.
