On Fri, Oct 25, 2024 at 09:55:38PM GMT, Yu Zhao wrote: > On Thu, Oct 24, 2024 at 7:23 PM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: > > > > While updating the generation of the folios, MGLRU requires that the > > folio's memcg association remains stable. With the charge migration > > deprecated, there is no need for MGLRU to acquire locks to keep the > > folio and memcg association stable. > > > > Signed-off-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > > --- > > mm/vmscan.c | 11 ----------- > > 1 file changed, 11 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 29c098790b01..fd7171658b63 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -3662,10 +3662,6 @@ static void walk_mm(struct mm_struct *mm, struct lru_gen_mm_walk *walk) > > if (walk->seq != max_seq) > > break; > > Please remove the lingering `struct mem_cgroup *memcg` as well as > folio_memcg_rcu(). Otherwise it causes both build and lockdep > warnings. > Thanks for catching this. The unused warning is already fixed by Andrew, I will fix the folio_memcg_rcu() usage.
