On Tue 15-10-24 11:55:26, Ryan Roberts wrote: > On 14/10/2024 20:59, Shakeel Butt wrote: > > On Mon, Oct 14, 2024 at 11:58:10AM GMT, Ryan Roberts wrote: > >> Previously the seq_buf used for accumulating the memory.stat output was > >> sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; > >> If 4K is enough on a 4K page system, then it should also be enough on a > >> 64K page system, so we can save 60K om the static buffer used in > >> mem_cgroup_print_oom_meminfo(). Let's make it so. > >> > >> This also has the beneficial side effect of removing a place in the code > >> that assumed PAGE_SIZE is a compile-time constant. So this helps our > >> quest towards supporting boot-time page size selection. > >> > >> Signed-off-by: Ryan Roberts <ryan.roberts@xxxxxxx> > > > > Acked-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > > Thanks Shakeel and Johannes, for the acks. Given this patch is totally > independent, I'll plan to resubmit it on its own and hopefully we can get it in > independently of the rest of the series. Yes, this makes sense independent on the whole series. Acked-by: Michal Hocko <mhocko@xxxxxxxx> Thanks! -- Michal Hocko SUSE Labs
