Hello, On Mon, Sep 30, 2024 at 04:52:58PM +0800, Yu Kuai wrote: > +static inline bool blkg_print_dev_name(struct seq_file *sf, > + struct blkcg_gq *blkg) > +{ > + struct gendisk *disk = blkg->q->disk; > + > + if (!disk) > + return false; > + > + seq_printf(sf, "%u:%u", disk->major, disk->first_minor); > + return true; > +} > + I wonder whether we just should add a name field to disk. Thanks. -- tejun