On Mon, Aug 26, 2024 at 03:30:14PM -0400, Waiman Long wrote: ... > Another alternative is to include cpuset-v1.c directly into cpuset.c like > > #ifdef CONFIG_CPUSETS_V1 > #include "cpuset-v1.c" > #else > .... > #endif > > Then you don't need to change the names and will not need cpuset-internal.h. > It is up to you to decide what you want to do. FWIW, I'd prefer to have cpuset1_ prefixed functions declared in cpuset1.h or something rather than including .c file. Thanks. -- tejun