On Fri, Aug 16, 2024 at 12:27:27PM GMT, Kinsey Ho <kinseyho@xxxxxxxxxx> wrote: > Hi Michal, > > > I may be missing (literal) context but I'd suggest not moving the memcg > > assignment and leverage > > if (memcg != NULL) > > css_put(memcg->css) > > so that the is-root comparison needn't be repeated. > > I might also be misunderstanding you with respect to the is-root > comparison – the reason the memcg assignment is moved is because it is > possible that on the restart added in this patch, css could be NULL. I've played with this applied up to 4/5 and I see more changes would be needed to preserve the function. Please disregard my initial suggestion ':-) Michal
Attachment:
signature.asc
Description: PGP signature
