On 5/16/24 12:05, Shuah Khan wrote:
On 5/16/24 11:45, Tejun Heo wrote:
Hello,
On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote:
I am exploring options and leaning towards reverting the patch
daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE")
Your amending the PR helps me if I have to send revert. I am sorry
for the trouble.
I can all of them together in a second update or after the merge window
closes.
The cgroup commit is already pulled in unfortunately. Can you please handle
the revert and whatever's necessary to fix up the situation? I'll ask you
what to do with selftest patches from now on.
Thanks for the update. Yes I am working on fixing the situation and
will send revert for cgroup test patch as well if necessary.
No worries. It is not a problem for you to handle cgroup test patches
in general. I will need your review anyway and letting you handle them
reduces the overhead.
This kind of framework change causes needs to be coordinated.
I should have held back on the framework change on my part.
As mentioned in the other thread
https://lore.kernel.org/linux-kselftest/24975952-b1fa-44a5-bac5-aef538ad0c09@xxxxxxxxxxxxxxxxxxx/T/#t
I reverted the following patch and the framework change patch.
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
Will send PR to Linus this weekend.
"selftests/cgroup: Drop define _GNU_SOURCE"
commit c1457d9aad5ee2feafcf85aa9a58ab50500159d2
thanks,
-- Shuah
