On Fri, 19 Apr 2024 17:32:57 +0800, linan666@xxxxxxxxxxxxxxx wrote: > In iocg_pay_debt(), warn is triggered if 'active_list' is empty, which > is intended to confirm iocg is avitve when it has debt. However, warn > can be triggered during a blkcg or disk is being removed, as > iocg_waitq_timer_fn() is awakened at that time. > > WARNING: CPU: 0 PID: 2344971 at block/blk-iocost.c:1402 iocg_pay_debt+0x14c/0x190 > Call trace: > iocg_pay_debt+0x14c/0x190 > iocg_kick_waitq+0x438/0x4c0 > iocg_waitq_timer_fn+0xd8/0x130 > __run_hrtimer+0x144/0x45c > __hrtimer_run_queues+0x16c/0x244 > hrtimer_interrupt+0x2cc/0x7b0 > ps: This issue was got in linux 5.10, but it also exists in the mainline. > > [...] Applied, thanks! [1/1] blk-iocost: do not WARNING if iocg has already offlined commit: 01bc4fda9ea0a6b52f12326486f07a4910666cf6 Best regards, -- Jens Axboe