On Thu, 2024-04-04 at 12:05 -0500, Haitao Huang wrote: > > > -static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg) > > > +static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg, > > > enum sgx_reclaim r) > > > > Is the @r here intentional for shorter typing? > > > > yes :-) > Will speel out to make it consistent if that's the concern. I kinda prefer the full name to match the CONFIG_CGROUP_SGX_EPC on case. You can put the 'enum sgx_reclaim reclaim' parameter into the new line if needed: static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg, enum sgx_reclaim reclaim) { return 0; }