On Wed, 27 Mar 2024 19:57:26 -0500, Haitao Huang
<haitao.huang@xxxxxxxxxxxxxxx> wrote:
On Wed, 27 Mar 2024 11:56:35 -0500, Jarkko Sakkinen <jarkko@xxxxxxxxxx>
wrote:
On Wed Mar 27, 2024 at 2:55 PM EET, Jarkko Sakkinen wrote:
On Mon, 2024-02-05 at 13:06 -0800, Haitao Huang wrote:
> The scripts rely on cgroup-tools package from libcgroup [1].
>
> To run selftests for epc cgroup:
>
> sudo ./run_epc_cg_selftests.sh
>
> To watch misc cgroup 'current' changes during testing, run this in a
> separate terminal:
...
> wait_and_detect_for_any() {
what is "any"?
Maybe for some key functions could have short documentation what they
are and for what test uses them. I cannot possibly remember all of this
just by hints such as "this waits for Any" ;-)
I don't think there is actual kernel guideline to engineer the script
to work with just ash but at least for me that would inevitably
increase my motivation to test this patch set more rather than less.
I also wonder is cgroup-tools dependency absolutely required or could
you just have a function that would interact with sysfs?
I should have checked email before hit the send button for v10 :-).
It'd be more complicated and less readable to do all the stuff without
the cgroup-tools, esp cgexec. I checked dependency, cgroup-tools only
depends on libc so I hope this would not cause too much inconvenience.
I saw bash was also used in cgroup test scripts so at least that's
consistent :-)
I can look into ash if that's required. Let me know.
Sorry I missed you earlier comments. I actually tried to make it
compatible with busybox on Ubuntu.
I'll address your other comments and update. But meanwhile could you
tryout this version in your env?
https://github.com/haitaohuang/linux/commit/3c424b841cf3cf66b085a424f4b537fbc3bbff6f
Thanks
Haitao
