Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
From: Kent Overstreet <kent.overstreet@xxxxxxxxx>
Date: Mon, 12 Feb 2024 21:08:48 -0500
Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, mhocko@xxxxxxxx, vbabka@xxxxxxx, hannes@xxxxxxxxxxx, roman.gushchin@xxxxxxxxx, mgorman@xxxxxxx, dave@xxxxxxxxxxxx, willy@xxxxxxxxxxxxx, liam.howlett@xxxxxxxxxx, corbet@xxxxxxx, void@xxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, juri.lelli@xxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, arnd@xxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, peterx@xxxxxxxxxx, david@xxxxxxxxxx, axboe@xxxxxxxxx, mcgrof@xxxxxxxxxx, masahiroy@xxxxxxxxxx, nathan@xxxxxxxxxx, dennis@xxxxxxxxxx, tj@xxxxxxxxxx, muchun.song@xxxxxxxxx, rppt@xxxxxxxxxx, paulmck@xxxxxxxxxx, pasha.tatashin@xxxxxxxxxx, yosryahmed@xxxxxxxxxx, yuzhao@xxxxxxxxxx, dhowells@xxxxxxxxxx, hughd@xxxxxxxxxx, andreyknvl@xxxxxxxxx, ndesaulniers@xxxxxxxxxx, vvvvvv@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, ebiggers@xxxxxxxxxx, ytcoode@xxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, bsegall@xxxxxxxxxx, bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, cl@xxxxxxxxx, penberg@xxxxxxxxxx, iamjoonsoo.kim@xxxxxxx, 42.hyeyoo@xxxxxxxxx, glider@xxxxxxxxxx, elver@xxxxxxxxxx, dvyukov@xxxxxxxxxx, shakeelb@xxxxxxxxxx, songmuchun@xxxxxxxxxxxxx, jbaron@xxxxxxxxxx, rientjes@xxxxxxxxxx, minchan@xxxxxxxxxx, kaleshsingh@xxxxxxxxxx, kernel-team@xxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-modules@xxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx
In-reply-to: <202402121631.5954CFB@keescook>
References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook>

On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote:
> On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote:
> > From: Kent Overstreet <kent.overstreet@xxxxxxxxx>
> > 
> > It seems we need to be more forceful with the compiler on this one.
> 
> Sure, but why?

Wasn't getting inlined without it, and that's one we do want inlined -
it's only called in one place.

Follow-Ups:
- Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
  - From: Vlastimil Babka

References:
- [PATCH v3 00/35] Memory allocation profiling
  - From: Suren Baghdasaryan
- [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
  - From: Suren Baghdasaryan
- Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
  - From: Kees Cook

Prev by Date: Re: [PATCH v3 10/35] lib: code tagging framework
Next by Date: Re: [PATCH v3 05/35] mm: introduce slabobj_ext to support slab object extensions
Previous by thread: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
Next by thread: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]