On Fri, Dec 22, 2023 at 06:29:43AM +0900, Tejun Heo wrote:
> On Fri, Dec 08, 2023 at 10:33:09AM +0100, Max Kellermann wrote:
> > By passing the fsugid to kernfs_create_dir_ns(), we don't need
> > cgroup_kn_set_ugid() any longer. That function was added for exactly
> > this purpose by commit 49957f8e2a43 ("cgroup: newly created dirs and
> > files should be owned by the creator").
> >
> > Eliminating this piece of duplicate code means we benefit from future
> > improvements to kernfs_create_dir_ns(); for example, both are lacking
> > S_ISGID support currently, which my next patch will add to
> > kernfs_create_dir_ns(). It cannot (easily) be added to
> > cgroup_kn_set_ugid() because we can't dereference struct kernfs_iattrs
> > from there.
> >
> > Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
> > Acked-by: Tejun Heo <tj@xxxxxxxxxx>
>
> Applied to cgroup/for-6.8. Greg, can you please take the second patch?
Both are already in my tree, thanks.
greg k-h
