On Wed, Sep 13, 2023 at 08:09:55AM -0300, Christoph Hellwig wrote: > Return early for the case where the super block isn't cleaned up to > reduce level of indentation. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > fs/super.c | 35 ++++++++++++++++++----------------- > 1 file changed, 18 insertions(+), 17 deletions(-) > > diff --git a/fs/super.c b/fs/super.c > index 2d762ce67f6e6c..127a17d958a482 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -476,27 +476,28 @@ static void kill_super_notify(struct super_block *sb) > void deactivate_locked_super(struct super_block *s) I wouldn't mind s/s/sb/ here as well. So we stop using @s in some and @sb in other places. Otherwise looks good to me, Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>