On Thu, 20 Jul 2023 20:14:41 +0800, chengming.zhou@xxxxxxxxx wrote:
> The flush bio may have data, may have no data (empty flush), we couldn't
> calculate cost for empty flush bio. So we'd better just skip it for now.
>
> Another side effect is that empty flush bio's bio_end_sector() is 0, cause
> iocg->cursor reset to 0, may break the cost calculation of other bios.
>
> This isn't good enough, since flush bio still consume the device bandwidth,
> but flush request is special, can be merged randomly in the flush state
> machine, we don't know how to calculate cost for it for now.
>
> [...]
Applied, thanks!
[1/1] blk-iocost: skip empty flush bio in iocost
commit: 013adcbef165c3eaf73e297b7482290593815ab8
Best regards,
--
Jens Axboe
