On Mon Jul 17, 2023 at 12:41 PM UTC, Jarkko Sakkinen wrote: > On Wed Jul 12, 2023 at 11:01 PM UTC, Haitao Huang wrote: > > From: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > > Two types of owners, 'sgx_encl' for VA pages and 'sgx_encl_page' for other, > > can be stored in the union field in sgx_epc_page struct introduced in the > > previous patch. > > This would be easier to follow: > > "Two types of owners of struct_epc_page, 'sgx_encl' for VA pages and > 'sgx_encl_page' can be stored in the previously introduced union field." > > > When cgroup OOM support is added in a later patch, the owning enclave of a > > page will need to be identified. Retrieving the sgx_encl struct from a > > sgx_epc_page will be different if the page is a VA page vs. other enclave > > pages. > > > > Add 2 flags which will identify the type of the owner and apply them > > accordingly to newly allocated pages. > > This would be easier to follow: > > "OOM support for cgroups requires that the owner needs to be identified > when selecting pages from the unreclaimable list. Address this by adding > flags for identifying the owner type." > > It is better to carry the story a little bit forward than say that a > subsequent patch will require this :-) I.e. enough to get at least a > rough idea what is going on. Oops, sent by mistake. I was going to say that the flag would be better named simply as SGX_EPC_OWNER_PAGE instead of SGX_EPC_OWNER_ENCL_PAGE. BR, Jarkko
