On 2023/7/10 23:46, Michal Koutný wrote:
> Hi.
>
> On Sat, Jul 01, 2023 at 03:38:56PM +0800, Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>> The return value of cgroup_rm_cftypes_locked() is always 0. So remove
>> it to simplify the code. No functional change intended.
>
> I'd add a comment that it builds upon cgroup_addrm_files()'s:
Do you mean something like below:
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index b0d98542eea2..2c02f319a7d4 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -4320,6 +4320,7 @@ static int cgroup_init_cftypes(struct cgroup_subsys *ss, struct cftype *cfts)
return ret;
}
+/* It builds upon cgroup_addrm_files()'s. */
static void cgroup_rm_cftypes_locked(struct cftype *cfts)
{
lockdep_assert_held(&cgroup_mutex);
>> For removals, this function never fails.
>
>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>> ---
>> kernel/cgroup/cgroup.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> Reviewed-by: Michal Koutný <mkoutny@xxxxxxxx>
Thanks for review and suggestion.
