On Wed, May 24, 2023 at 02:54:10PM +0800, Hao Jia <jiahao.os@xxxxxxxxxxxxx> wrote: > Yes, so we need @curr to record the bstat value after the sequence fetch is > completed. No, I still don't see a problem that it solves. If you find incorrect data being reported, please explain it more/with an example. > Yes, but it may not be obvious. > Another reason is that when we complete an update, we snapshot last_bstat as > the current bstat, which is better for readers to understand. Arithmetics is > somewhat obscure. The readability here is subjective. It'd be interesting to have some data comparing arithmetics vs copying though. HTH, Michal
Attachment:
signature.asc
Description: PGP signature