On Thu, Apr 13, 2023 at 12:07:53AM +0800, chengming.zhou@xxxxxxxxx wrote: > From: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> > > We need to set QUEUE_FLAG_STATS for two cases: > 1. blk_stat_enable_accounting() > 2. blk_stat_add_callback() > > So we should clear it only when ((q->stats->accounting == 0) && > list_empty(&q->stats->callbacks)). > > blk_stat_disable_accounting() only check if q->stats->accounting > is 0 before clear the flag, this patch fix it. > > Also add list_empty(&q->stats->callbacks)) check when enable, or > the flag is already set. > > Signed-off-by: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> It'd be useful to explicitly illustrate the buggy behavior in the description (e.g. if you do X, Y and then Z, then X incorrectly loses accounting). Can you also please add the appropriate stable cc? Thanks. -- tejun
