Re: [PATCH 2/2] sched/psi: iterate through cgroups directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Weiner <hannes@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
From: Michal Koutný <mkoutny@xxxxxxxx>
Date: Wed, 8 Feb 2023 23:03:19 +0100
Cc: Kairui Song <ryncsn@xxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Chengming Zhou <zhouchengming@xxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, cgroups@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Kairui Song <kasong@xxxxxxxxxxx>
In-reply-to: <Y+P0wLTdZcOPiKPZ@cmpxchg.org>
References: <20230208161654.99556-1-ryncsn@gmail.com> <20230208161654.99556-3-ryncsn@gmail.com> <Y+P0wLTdZcOPiKPZ@cmpxchg.org>

On Wed, Feb 08, 2023 at 02:15:12PM -0500, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> Please name these psi_groups_first() and psi_groups_next().

One more suggestion: s/next/parent/ to avoid impression of (sub)tree
iteration and consistence with cg-related iters.

Thanks,
Michal

Follow-Ups:
- Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
  - From: Kairui Song

References:
- [PATCH 0/2] sched/psi: Optimize PSI iteration
  - From: Kairui Song
- [PATCH 2/2] sched/psi: iterate through cgroups directly
  - From: Kairui Song
- Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
  - From: Johannes Weiner

Prev by Date: Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
Next by Date: Re: [PATCH] blk-ioprio: Introduce promote-to-rt policy
Previous by thread: Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
Next by thread: Re: [PATCH 2/2] sched/psi: iterate through cgroups directly
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]

Powered by Linux