Re: [PATCH 03/19] blk-cgroup: improve error unwinding in blkg_alloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 01, 2023 at 02:41:07PM +0100, Christoph Hellwig wrote:
> Unwind only the previous initialization steps that happened in blkg_alloc
> using goto based unwinding.  This avoids the need for the !queue special
> case in blkg_free.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This is fine but is this necessarily better? If it's needed for future
changes, maybe that should be mentioned?

 Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux