On Tue, Jan 24, 2023 at 07:57:01AM +0100, Christoph Hellwig wrote: > Now that blk_put_queue can be called from process context, there is no s/process/atomic? > need for the asynchronous execution. > > This effectively reverts commit d578c770c85233af592e54537f93f3831bde7e9a. blkg_free() can be called with ->queue_lock, and: - del_timer_sync(&tg->service_queue.pending_timer) is called from throtl_pd_free(). - queue_lock is required by throtl_pending_timer_fn So there is deadlock risk if the above commit is reverted. Thanks, Ming