On 2022/11/29 01:07, Tejun Heo wrote: > On Fri, Nov 25, 2022 at 07:51:33AM +0000, haifeng.xu wrote: >> cpuset_task_status_allowed just shows mems_allowed status, so >> rename it to task_mems_allowed. Moreover, it's only used in >> proc_pid_status, so move it to fs/proc/array.c. There is no >> intentional function change. >> >> Signed-off-by: haifeng.xu <haifeng.xu@xxxxxxxxxx> > > mems_allowed being a very much cpuset feature, I don't see how this is an > improvement. The new code is different and can be another way of doing it, > sure, but there's no inherent benefit to it. What's the point of the churn? > > Thanks. > Hi, tejun. In proc_pid_status, task_cpus_allowed is used to show cpus_allowed, similar to that, task_mems_allowed is more specific to show mems_allowed. Also cpuset_task_status_allowed is used to dispaly memory status in '/proc/<pid>/status' and isn't used in other files, so keep it in the fs/proc/array.c. Thanks, Haifeng.
