On Thu, Nov 17, 2022 at 3:18 AM Kamalesh Babulal <kamalesh.babulal@xxxxxxxxxx> wrote: > > Change the function argument in the description of cpuset_css_alloc() > from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the > argument type was introduced by commit eb95419b023a ("cgroup: pass > around cgroup_subsys_state instead of cgroup in subsystem methods"). > Also, add more information to its description. > > Signed-off-by: Kamalesh Babulal <kamalesh.babulal@xxxxxxxxxx> > --- > v2: Reworded the description to be more accurate, as suggested > by Waiman Long > > kernel/cgroup/cpuset.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index b474289c15b8..ce789e1b2a2f 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3046,11 +3046,15 @@ static struct cftype dfl_files[] = { > }; > > > -/* > - * cpuset_css_alloc - allocate a cpuset css > - * cgrp: control group that the new cpuset will be part of > +/** > + * cpuset_css_alloc - Allocate a cpuset css > + * @parent_css: Parent css of the control group that the new cpuset will be > + * part of > + * Return: cpuset css on success, -ENOMEM on failure. > + * > + * Allocate and initialize a new cpuset css, for non-NULL @parent_css, return > + * top cpuset css otherwise. > */ > - > static struct cgroup_subsys_state * > cpuset_css_alloc(struct cgroup_subsys_state *parent_css) > { > -- > 2.34.3 > Acked-by: Joel Savitz <jsavitz@xxxxxxxxxx>