On 2022/11/3 10:31, Tejun Heo wrote: > On Thu, Nov 03, 2022 at 10:13:22AM +0800, Haifeng Xu wrote: >> I understand your worries. Can I just check the populated state of >> css_set in 'css_set_update_populated' and don't change the order any >> more? I think it can also streamline 'css_set_move_task' a bit. > > FWIW, I don't see much value in the proposed change. The resulting code > isn't better in any noticeable way. Even if the change were straightforward, > the value of the patch would seem questionable. There's no point in creating > code churns like this. Nothing is improved in any material way while > creating completely unnecessary risk for subtle breakages. > > Thanks. > Got it, thanks.