On Fri, Oct 21, 2022 at 10:40 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Fri, 21 Oct 2022 09:34:20 -0700 Shakeel Butt wrote: > > > > How about just using gfp_any() and we can remove gfp_memcg_charge()? > > > > > > How about keeping gfp_memcg_charge() and adding a comment on its intent ? > > > > > > gfp_any() is very generic :/ > > That was my thinking, and I'm not sure what I could put in a comment. > Wouldn't it be some mix of words 'flags', 'memory', 'cgroup' and > 'charge'... which is just spelling out the name of the function? > > I mean: > > /* Alloc flags for passing to cgroup socket memory charging */ > > does not add much value, right? Yeah I agree. Let's just go with the original patch. You can add: Acked-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
