Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
Subject: Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Mon, 10 Oct 2022 14:11:08 -1000
Cc: Zefan Li <lizefan.x@xxxxxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, cgroups@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx
In-reply-to: <20221010235845.3379019-3-yosryahmed@google.com>
References: <20221010235845.3379019-1-yosryahmed@google.com> <20221010235845.3379019-3-yosryahmed@google.com>

On Mon, Oct 10, 2022 at 11:58:44PM +0000, Yosry Ahmed wrote:
> Add cgroup_all_get_from_fd() and cgroup_all_get_from_file() that
> support both cgroup1 and cgroup2.

Looks generally good. How about cgroup_v1v2_ as the prefix?

Thanks.

-- 
tejun

Follow-Ups:
- Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
  - From: Yosry Ahmed

References:
- [PATCH v1 0/3] Fix cgroup1 support in get from fd/file interfaces
  - From: Yosry Ahmed
- [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
  - From: Yosry Ahmed

Prev by Date: Re: [PATCH v1 1/3] Revert "cgroup: enable cgroup_get_from_file() on cgroup1"
Next by Date: Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
Previous by thread: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
Next by thread: Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]