Re: [PATCH -next] cgroup: simplify code in cgroup_apply_control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 9/17/2022 2:10 PM, williamsukatube@xxxxxxx wrote:
From: William Dean <williamsukatube@xxxxxxx>

It could directly return 'cgroup_update_dfl_csses' to simplify code.

Signed-off-by: William Dean <williamsukatube@xxxxxxx>
---
  kernel/cgroup/cgroup.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index e4bb5d57f4d1..1958f8bd93d6 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
  	 * making the following cgroup_update_dfl_csses() properly update
  	 * css associations of all tasks in the subtree.
  	 */
-	ret = cgroup_update_dfl_csses(cgrp);
-	if (ret)
-		return ret;
-
-	return 0;
+	return cgroup_update_dfl_csses(cgrp);
  }

  /**
--
2.25.1


LGTM.

Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux