Hello, On Mon, Sep 05, 2022 at 03:14:35PM +0200, Michal Koutný wrote: > IIUC, the flag is equal to (cft->ss || cft->kf_ops), particularly the > information is carried in cfs->kf_ops too. ->ss will be NULL for core files even after added. ->kf_ops can be used instead of the flag. > Is the effect of cgroup_init_cftypes proper setup of cft->kf_ops? > I.e. isn't it simpler to just check that field (without the new flag)? > > (No objection to current form, just asking whether I understand the > impact.) I prefer having it as a separate flag because it's explicit and can be tested together with other flags. It's a weak preference tho and I can go either way if it bothers you much. Thanks. -- tejun
