On Tue, Aug 23, 2022, at 4:12 PM, Tejun Heo wrote: > On Tue, Aug 23, 2022 at 02:59:29PM -0400, Chris Murphy wrote: >> Same VM but a different boot: >> >> Excerpts: >> >> /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/session.slice/gvfs-goa-volume-monitor.service/io.pressure:some avg10=3031575.41 avg60=56713935870.67 avg300=624837039080.83 total=18446621498826359 >> /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/session.slice/gvfs-goa-volume-monitor.service/io.pressure:full avg10=3031575.41 avg60=56713935870.80 avg300=624837039080.99 total=16045481047390973 >> >> None of that seems possible. >> >> io is also affected: >> >> /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/session.slice/org.gnome.SettingsDaemon.Smartcard.service/io.pressure:full avg10=0.00 avg60=0.13 avg300=626490311370.87 total=16045481047397307 >> >> # oomctl >> # grep -R . /sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/ >> https://drive.google.com/file/d/1JoUxjQ2ribDvn5jmydCWXJdg0daaNScG/view?usp=sharing >> >> We're going to try reverting 5f69a6577bc33d8f6d6bbe02bccdeb357b287f56 and see if it helps. > > Can you see whether the following helps? > > Thanks. > > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c > index ec66b40bdd40..00d62681ea6a 100644 > --- a/kernel/sched/psi.c > +++ b/kernel/sched/psi.c > @@ -957,7 +957,7 @@ int psi_cgroup_alloc(struct cgroup *cgroup) > if (static_branch_likely(&psi_disabled)) > return 0; > > - cgroup->psi = kmalloc(sizeof(struct psi_group), GFP_KERNEL); > + cgroup->psi = kzalloc(sizeof(struct psi_group), GFP_KERNEL); > if (!cgroup->psi) > return -ENOMEM; Looks like it's fixed in limited testing. It'll get put into Rawhide and automated testing today hopefully. Thanks! -- Chris Murphy
