On Thu, Aug 18, 2022 at 05:29:39PM +0800, Yu Kuai wrote: > Hi, Tejun! > > 在 2022/08/18 1:54, Tejun Heo 写道: > > Hello, > > > > On Wed, Aug 17, 2022 at 09:45:13AM +0800, Yu Kuai wrote: > > > > I don't know whether this is better or not. It's minutely less lines of code > > > > but also makes the code a bit more fragile. I'm ambivalent. At any rate, > > > > please move these trivial patches to the head of the series or post them > > > > separately. > > > > > > Can I ask why do you think this patch makes the code a bit more fragile? > > > > It's just one step further removed. Before, the flag was trivially in sync > > with the on queue status. After, the relationship is more indirect and > > easier to break accidentally. Not that it's a major problem. Just not sure > > what the benefit of the change is. > > If you are worried about that, I can keep the flag, then the last two > patches will cleanup: I wasn't necessarily worried. It's more that I couldn't tell why the code is better afterwards. Maybe update the commit message to explain why the new code is better? Thanks. -- tejun
