Hello, Waiman. On Thu, Jul 28, 2022 at 05:04:19PM -0400, Waiman Long wrote: > > So, the patch you proposed is making the code remember one special aspect of > > user requested configuration - whether it configured it or not, and trying > > to preserve that particular state as cpuset state changes. It addresses the > > immediate problem but it is a very partial approach. Let's say a task wanna > > be affined to one logical thread of each core and set its mask to 0x5555. > > Now, let's say cpuset got enabled and enforced 0xff and affined the task to > > 0xff. After a while, the cgroup got more cpus allocated and its cpuset now > > has 0xfff. Ideally, what should happen is the task now having the effective > > mask of 0x555. In practice, tho, it either would get 0xf55 or 0x55 depending > > on which way we decide to misbehave. > > OK, I see what you want to accomplish. To fully address this issue, we will > need to have a new cpumask variable in the the task structure which will be > allocated if sched_setaffinity() is ever called. I can rework my patch to > use this approach. Yeah, we'd need to track what user requested separately from the currently effective cpumask. Let's make sure that the scheduler folks are on board before committing to the idea tho. Peter, Ingo, what do you guys think? Thanks. -- tejun
