On 6/2/22 12:16, Tejun Heo wrote:
On Thu, Jun 02, 2022 at 09:35:42AM -0400, Waiman Long wrote:
For blkcg_css_alloc(), the only error that will be returned is -ENOMEM.
Simplify error handling code by returning this error directly instead
of setting an intermediate "ret" variable.
Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
But I don't understand why this would trigger warning. Can you please
elaborate why this is needed.
Thanks.
I forgot to set "ret" in my original patch 2 in case of allocation
error. I didn't got a warning in my own build, maybe I didn't explicitly
enable more warning. I could have modified the patch to set "ret" on
error, but the "ret" setting looks duplicative to me and so I added this
patch to get rid of it.
Thanks,
Longman
