On 3/2/22 10:53, Michal Koutný wrote: > On Mon, Feb 21, 2022 at 04:58:11PM -0800, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> __setup() handlers should return 1 if the command line option is handled >> and 0 if not (or maybe never return 0; it just pollutes init's environment). > > Interesting. > >> Instead of relying on this '.' quirk, just return 1 to indicate that >> the boot option has been handled. > > But your patch would return 1 even when no accepted value was passed, > i.e. is the command line option considered handled in that case? Yes, for some definition of "handled." It was seen by the __setup handler. > Did you want to return 1 only when the cgroup.memory= value is > recognized? Not really. I did consider that (for all of the similar patches that I am posting). I don't think those strings (even with invalid option values) should be added to init's environment. I'm willing to add a pr_warn() or pr_notice() for any unrecognized option value, but it should still return 1 IMO. -- ~Randy
