Re: [PATCH] mm/memcg: Add missing counter index which are not update in interrupt.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Subject: Re: [PATCH] mm/memcg: Add missing counter index which are not update in interrupt.
From: Shakeel Butt <shakeelb@xxxxxxxxxx>
Date: Fri, 25 Feb 2022 09:08:22 -0800
Cc: Cgroups <cgroups@xxxxxxxxxxxxxxx>, Linux MM <linux-mm@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Michal Koutný <mkoutny@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vladimir Davydov <vdavydov.dev@xxxxxxxxx>, Waiman Long <longman@xxxxxxxxxx>, Roman Gushchin <guro@xxxxxx>
In-reply-to: <YhjzE/8LgbULbj/C@linutronix.de>
References: <20220221182540.380526-1-bigeasy@linutronix.de> <20220221182540.380526-4-bigeasy@linutronix.de> <CALvZod7DfxHp+_NenW+NY81WN_Li4kEx4rDodb2vKhpC==sd5g@mail.gmail.com> <YhjzE/8LgbULbj/C@linutronix.de>

On Fri, Feb 25, 2022 at 7:17 AM Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> Shakeel Butt reported that I missed a few counters which are not updated
> in-interrupt context and therefore disabling preemption is fine.
>
> Please fold into:
>      "Protect per-CPU counter by disabling preemption on PREEMPT_RT"
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Thanks. For the folded patch:

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>

Follow-Ups:
- [PATCH] mm/memcg: Only perform the debug checks on !PREEMPT_RT
  - From: Sebastian Andrzej Siewior

References:
- [PATCH v4 0/6] mm/memcg: Address PREEMPT_RT problems instead of disabling it.
  - From: Sebastian Andrzej Siewior
- [PATCH v4 3/6] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed.
  - From: Sebastian Andrzej Siewior
- Re: [PATCH v4 3/6] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed.
  - From: Shakeel Butt
- [PATCH] mm/memcg: Add missing counter index which are not update in interrupt.
  - From: Sebastian Andrzej Siewior

Prev by Date: Explanation for difference between memcg swap accounting and smaps_rollup
Next by Date: Re: [PATCH v2] KVM: Move VM's worker kthreads back to the original cgroups before exiting.
Previous by thread: [PATCH] mm/memcg: Add missing counter index which are not update in interrupt.
Next by thread: [PATCH] mm/memcg: Only perform the debug checks on !PREEMPT_RT
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]