Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michal Hocko <mhocko@xxxxxxxx>
Subject: Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Date: Mon, 21 Feb 2022 18:25:12 +0100
Cc: cgroups@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Michal Koutný <mkoutny@xxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vladimir Davydov <vdavydov.dev@xxxxxxxxx>, Waiman Long <longman@xxxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>
In-reply-to: <YhPJM4RjqklanVLE@dhcp22.suse.cz>
References: <20220217094802.3644569-1-bigeasy@linutronix.de> <20220217094802.3644569-6-bigeasy@linutronix.de> <YhOlxsLOOU/OVSzu@dhcp22.suse.cz> <YhOtmPQUcqZCKodH@linutronix.de> <YhO8yQrdVX04T8/n@dhcp22.suse.cz> <YhPBXUmIIHeXI/Gz@linutronix.de> <YhPJM4RjqklanVLE@dhcp22.suse.cz>

On 2022-02-21 18:17:39 [+0100], Michal Hocko wrote:
> > What about if replace get_cpu() with migrate_disable()? 
> 
> Yeah, that would be a better option. I am just not used to think in RT
> so migrate_disable didn't really come to my mind.

Good.
Let me rebase accordingly, new version is coming soon.

Side note: migrate_disable() is by now implemented in !RT and used in
highmem for instance (kmap_atomic()).

Sebastian

References:
- [PATCH v3 0/5] mm/memcg: Address PREEMPT_RT problems instead of disabling it.
  - From: Sebastian Andrzej Siewior
- [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Sebastian Andrzej Siewior
- Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Michal Hocko
- Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Sebastian Andrzej Siewior
- Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Michal Hocko
- Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Sebastian Andrzej Siewior
- Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
  - From: Michal Hocko

Prev by Date: Re: [PATCH v3 3/5] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed.
Next by Date: Re: [PATCH v3 1/5] mm/memcg: Revert ("mm/memcg: optimize user context object stock access")
Previous by thread: Re: [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t
Next by thread: [PATCH v3 3/5] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed.
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]