On 2022-02-16 13:08:55 [-0500], Johannes Weiner wrote:
> I thought you'd fold it into yours, but separate patch works too,
> thanks!
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Thank you.
> One important note, though:
>
> > @@ -3151,8 +3155,17 @@ static void drain_obj_stock(struct memcg_stock_pcp *stock)
> > unsigned int nr_pages = stock->nr_bytes >> PAGE_SHIFT;
> > unsigned int nr_bytes = stock->nr_bytes & (PAGE_SIZE - 1);
> >
> > - if (nr_pages)
> > - obj_cgroup_uncharge_pages(old, nr_pages);
> > + if (nr_pages) {
> > + struct mem_cgroup *memcg;
> > +
> > + memcg = get_mem_cgroup_from_objcg(old);
> > +
> > + if (!cgroup_subsys_on_dfl(memory_cgrp_subsys))
> > + page_counter_uncharge(&memcg->kmem, nr_pages);
> > + __refill_stock(memcg, nr_pages);
>
> This doesn't take "memcg: add per-memcg total kernel memory stat"
> queued in -mm into account and so will break kmem accounting.
>
> Make sure to rebase the patches to the -mm tree before sending it
> out. You can find it here: https://github.com/hnaz/linux-mm
Thank you, rebased on-top.
Sebastian
