On Wed 26-01-22 15:45:20, Sebastian Andrzej Siewior wrote: > On 2022-01-26 15:40:54 [+0100], Michal Hocko wrote: > > I still support this approach but the patch is much larger than > > necessary. The code moving shouldn't be really necessary and a simple > > "do not allow" to set any thresholds or soft limit should be good > > enough. > > > > While in general it is better to disable the unreachable code I do not > > think this is worth the code churn here. > > I got the "defined but not used" warnings by the compiler after I > disabled the two functions. Then I moved everything to one code block to > avoid the multiple ifdefs. > If that is not good, let me think of something else… If this is really needed then just split the patch into two. First to add the special RT handling and the other one to move the code without any other changes. -- Michal Hocko SUSE Labs
