On Thu, Sep 09, 2021 at 09:49:56AM -0700, Vipin Sharma <vipinsh@xxxxxxxxxx> wrote: > We are adding two files in this patch series, misc.events and > misc.events.local. I think "fail" should go in misc.events.local and > its name should be changed to "max". I consider the max vs fail orthogonal to local vs hierarchical. I.e. both entries can be in both files: (1) misc.events.local:max number of times the cgroup's misc.max was hit (2) misc.events.local:fail number of times operation failed in the cgroup (3) misc.events:max number of times the cgroup's misc.max was hit in the subtree (4) misc.events:fail number of times operation failed in the subtree Is that too many? Admittedly, I assume (1) and (4) will be the more useful ones. However, I'm afraid overloading "max" as suggested might be (more) confusing. ('subtree' above := self or descendant) Michal