Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Subject: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex
From: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Date: Fri, 30 Jul 2021 10:42:29 +0800
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Vladimir Davydov <vdavydov.dev@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Shakeel Butt <shakeelb@xxxxxxxxxx>, Roman Gushchin <guro@xxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Alex Shi <alexs@xxxxxxxxxx>, Wei Yang <richard.weiyang@xxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Cgroups <cgroups@xxxxxxxxxxxxxxx>
In-reply-to: <20210729125755.16871-3-linmiaohe@huawei.com>
References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-3-linmiaohe@huawei.com>

On Thu, Jul 29, 2021 at 8:58 PM Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
>
> Since percpu_charge_mutex is only used inside drain_all_stock(), we can
> narrow the scope of percpu_charge_mutex by moving it here.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

LGTM.

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

References:
- [PATCH 0/5] Cleanups and fixup for memcontrol
  - From: Miaohe Lin
- [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex
  - From: Miaohe Lin

Prev by Date: Re: [PATCH 1/5] mm, memcg: remove unused functions
Next by Date: Re: [External] Re: [PATCH 5/5] mm, memcg: always call __mod_node_page_state() with preempt disabled
Previous by thread: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex
Next by thread: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]