On Thu, Jul 01, 2021 at 08:17:48AM +0100, Christoph Hellwig wrote: > On Wed, Jun 30, 2021 at 05:00:26AM +0100, Matthew Wilcox (Oracle) wrote: > > -void mem_cgroup_uncharge(struct page *page); > > +void mem_cgroup_uncharge(struct folio *); > > why do you drop the parameter name? I usually do where it's 'struct foo *foo' or 'foo_t foo'. If the best you can do is say "it's a page", well, yes, I knew that from the type. But since you've complained, I've added the pointless 'folio' to it. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
