On Wed 30-06-21 05:00:16, Matthew Wilcox wrote: > After Michel's comments on "Folio-enabling the page cache", I thought it > best to split out the memcg patches from the rest of the page cache folio > patches and redo them to focus on correctness (ie always passing a folio). > > This is fundamentally for review rather than application. I've rebased > on Linus' current tree, which includes the recent patchbomb from akpm. > That upstream version won't boot on any system I have available, and I'm > not comfortable asking for patches to be applied unless I can actually > try them. That said, these patches were fine on top of 5.13. > > There are still a few functions which take pages, but they rely on other > conversions happening first, which in turn rely on this set of patches, > so I think this is a good place to stop, with the understanding that > there will be more patches later. Thanks for considering the last review feedback. After looking at this pile the conversion is really straightforward and reasonably easy to review. There are still some cases where you opted to go with compatibility wrappers and I would still like to avoid those as it somehow obfuscates the conversion IMHO. As I've said previously, though, I do understand that this a tedious work so I do not want to make it more annoying unnecessarily for you. The replacement with page_folio for the replaced API looks better to me. If you have strong reasons (e.g. due to dependencies etc.) please make it explicit in the respective changelogs. Thanks! -- Michal Hocko SUSE Labs
