Hi Odin, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on tip/master linux/master linus/master v5.13-rc4 next-20210603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-220448 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 858f9e11be8855ed62cb97e58174515da595c76b config: i386-randconfig-r036-20210603 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/00f0e270f61d4f8a192ee519dda403d4656c910c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-220448 git checkout 00f0e270f61d4f8a192ee519dda403d4656c910c # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): kernel/sched/fair.c: In function 'cfs_rq_is_decayed': >> kernel/sched/fair.c:392:12: error: 'struct cfs_rq' has no member named 'avg' 392 | if (cfs_rq->avg.load_sum) | ^~ kernel/sched/fair.c:395:12: error: 'struct cfs_rq' has no member named 'avg' 395 | if (cfs_rq->avg.util_sum) | ^~ kernel/sched/fair.c:398:12: error: 'struct cfs_rq' has no member named 'avg' 398 | if (cfs_rq->avg.runnable_sum) | ^~ kernel/sched/fair.c: At top level: kernel/sched/fair.c:608:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes] 608 | int sched_update_scaling(void) | ^~~~~~~~~~~~~~~~~~~~ vim +392 kernel/sched/fair.c 381 382 /* Iterate thr' all leaf cfs_rq's on a runqueue */ 383 #define for_each_leaf_cfs_rq_safe(rq, cfs_rq, pos) \ 384 list_for_each_entry_safe(cfs_rq, pos, &rq->leaf_cfs_rq_list, \ 385 leaf_cfs_rq_list) 386 387 static inline bool cfs_rq_is_decayed(struct cfs_rq *cfs_rq) 388 { 389 if (cfs_rq->load.weight) 390 return false; 391 > 392 if (cfs_rq->avg.load_sum) 393 return false; 394 395 if (cfs_rq->avg.util_sum) 396 return false; 397 398 if (cfs_rq->avg.runnable_sum) 399 return false; 400 401 return true; 402 } 403 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
